Integration test for 570#712
Merged
Merged
Conversation
blackboxsw
reviewed
Dec 4, 2020
| VENDOR_DATA, | ||
| ) | ||
| client.execute('cloud-init clean --logs') | ||
| client.restart() |
Collaborator
There was a problem hiding this comment.
Now that we ignore restart errors from cloud-init in integration test instances. don't we need to either add a raise_errors=True param to IntegrationInstance.restart method or just call client.instance.restart() directly here which would wait and raise errors if we saw them across reboot?
Test that we can add optional vendor-data to the seedfrom file in a NoCloud environment
TheRealFalcon
force-pushed
the
test-gh570
branch
from
b904692 to
c4ebf4e
Compare
blackboxsw
approved these changes
Dec 4, 2020
This was referenced May 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Integration test for #570
Test that we can add optional vendor-data to the seedfrom file in a
NoCloud environment.
Also added the option to pass
raise_on_cloudinit_failurethroughan instance restart so we get automatic failure checking when
we need to manually reboot.
Additional Context
#570
Test Steps
should fail:
pytest tests/integration_tests/bugs/test_gh570.py
should pass:
CLOUD_INIT_CLOUD_INIT_SOURCE=PROPOSED pytest tests/integration_tests/bugs/test_gh570.py
Checklist: