integration_tests: add test for LP: #1898997#713
Conversation
This mark allows tests to pass in free-form configuration to the LXD instance being created. TODO: * Skip tests which specify this mark on non-LXD platforms.
ef60a24 to
313e660
Compare
|
This is now ready for review; it still needs canonical/pycloudlib#66 to land before it can land (so I've left the |
|
This is now ready for review (and subsequent landing, once our Travis issues are sorted). |
TheRealFalcon
left a comment
There was a problem hiding this comment.
Some minor questions/nits, but nothing that should prevent merging. Thanks for all the LXD yak shaving!
TheRealFalcon
left a comment
There was a problem hiding this comment.
Jk...just remembered something. You should update the commit hash of pycloudlib to the latest commit in integration-requirements.txt. I also forgot to do that in my last PR.
Ooh, good catch. I wonder if we should update the test steps to instruct people to manually run the integration tests using |
These will cause tests marked with them to be skipped on xenial and bionic respectively. The mechanism is semi-generic, so introducing new "not_*" marks should just be a case of adding them to tox.ini. (This also marks the test in `test_lp1898997.py` with these two marks.)
The latest commit includes the changes required for LXD network config to work.
Proposed Commit Message
Additional Context
This is WIP because it needs canonical/pycloudlib#66 to land for network config to LXD VMs to work.
Test Steps
Run
CLOUD_INIT_PLATFORM=lxd_vm pytest --log-cli-level=INFO tests/integration_tests/bugs/test_lp1898997.pyto see a failure.Run
CLOUD_INIT_PLATFORM=lxd_vm CLOUD_INIT_CLOUD_INIT_SOURCE=PROPOSED pytest --log-cli-level=INFO tests/integration_tests/bugs/test_lp1898997.pyto see a pass.Checklist: