integration_tests: restrict test_lxd_bridge appropriately#730
Merged
Conversation
TheRealFalcon
approved these changes
Dec 15, 2020
On xenial, the bridge test fails because xenial's LXD doesn't include the `network` subcommand. On bionic, the bridge test fails within containers, because LXD isn't able to manipulate the host kernel as it expects. (focal and later do run successfully in containers, but we don't have a good way of expressing that presently.)
OddBloke
changed the title
TheRealFalcon
approved these changes
Dec 15, 2020
This was referenced May 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Test Steps
CLOUD_INIT_OS_IMAGE=xenial pytest tests/integration_tests/modules/test_lxd_bridge.pyandCLOUD_INIT_OS_IMAGE=bionic pytest tests/integration_tests/modules/test_lxd_bridge.pyfail currently, and with this change instead passes (with all skips).CLOUD_INIT_PLATFORM=lxd_vm CLOUD_INIT_OS_IMAGE=xenial pytest tests/integration_tests/modules/test_lxd_bridge.pyfails currently, and with this change instead passes (with 1 skip, the bridge test).CLOUD_INIT_PLATFORM=lxd_vm CLOUD_INIT_OS_IMAGE=bionic pytest tests/integration_tests/modules/test_lxd_bridge.pyfails currently, and with this change instead passes.Checklist: