Skip to content

integration_tests: port ca_certs tests from cloud_tests#732

Merged
OddBloke merged 1 commit into
canonical:masterfrom
OddBloke:tests
Jan 4, 2021
Merged

integration_tests: port ca_certs tests from cloud_tests#732
OddBloke merged 1 commit into
canonical:masterfrom
OddBloke:tests

Conversation

@OddBloke
Copy link
Copy Markdown
Collaborator

Proposed Commit Message

integration_tests: port ca_certs tests from cloud_tests

Test Steps

Run pytest --log-cli-level=INFO tests/integration_tests/modules/test_ca_certs.py and observe success.

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this ubuntu only?

@OddBloke
Copy link
Copy Markdown
Collaborator Author

OddBloke commented Jan 4, 2021

Why is this ubuntu only?

It isn't exactly: the test relies on Ubuntu's file naming, but (sh|w)ould also run on Debian and Alpine; we don't have marks for those. The module under test also supports RHEL, but uses different filenames for that (so would need updating). I've added a couple of TODO items to the module-level docstring to capture this.

@OddBloke OddBloke merged commit aa72426 into canonical:master Jan 4, 2021
@OddBloke OddBloke deleted the tests branch January 4, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants