Datasource for UpCloud

[ajmyyra]

Datasource for UpCloud

New datasource utilizing UpCloud metadata API, including relevant unit tests and documentation.

Checklist:

• My code follows the process laid out in the documentation
• I have updated or added any unit tests accordingly
• I have updated or added any documentation accordingly

[ajmyyra]

CLA has been signed by UpCloud as an entity and sent to contributor-agreement@canonical.com on 18th of this month. No response yet, which isn't that surprising with holidays and end of year ongoing. :) Additionally, I added myself as a contributor in #742. Please let me know if there are additional steps needed for this, and of course if the PR itself is lacking something.

[TheRealFalcon]

Hi @ajmyyra . Overall this submission looks good. Along with my inline comments, I have two additional comments:

1. You'll need to update tools/ds-identify as well. That would involve adding to DI_DSLIST_DEFAULT, add a dscheck_UpCloud() (yours should look similar to DigitalOcean, and add a unit test to tests/unittests/test_ds_identify.py
2. In response to your exchange with OddBloke, I think yes, we'd prefer to use a v2 network config (for the reasons he listed) if it's not too much of a burden.

[ajmyyra]

Thank you for the review! I'll get these done later this week. Changing to v2 network config isn't too much work, so I'll gladly do it at the same time.

[TheRealFalcon]

This looks good to me now. I'll wait to see if @smoser has any additional comments, but if not it should be good to merge.

[smoser]

It does look fine to me. I'll approve. you can address my comments if you like... You should probably fix the retries comment if its wrong though.

[smoser]

meant to hit 'approve'.