Skip to content

First PR to comply with rules#747

Merged
OddBloke merged 4 commits into
canonical:masterfrom
chaporgin:patch-1
Jan 19, 2021
Merged

First PR to comply with rules#747
OddBloke merged 4 commits into
canonical:masterfrom
chaporgin:patch-1

Conversation

@chaporgin
Copy link
Copy Markdown
Contributor

@chaporgin chaporgin commented Jan 4, 2021

https://cloudinit.readthedocs.io/en/latest/topics/hacking.html

Proposed Commit Message

summary: no more than 70 characters

A description of what the change being made is and why it is being
made, if the summary line is insufficient.  The blank line above is
required. This should be wrapped at 72 characters, but otherwise has
no particular length requirements.

If you need to write multiple paragraphs, feel free.

LP: #NNNNNNN (replace with the appropriate bug reference or remove
this line entirely if there is no associated bug)

Additional Context

Test Steps

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

@chaporgin chaporgin changed the title antonyc wants to contribute First PR to comply Jan 4, 2021
@chaporgin chaporgin changed the title First PR to comply First PR to comply with rules Jan 4, 2021
@chaporgin chaporgin mentioned this pull request Jan 4, 2021
3 tasks
Copy link
Copy Markdown
Collaborator

@OddBloke OddBloke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Antony, I've confirmed that you've signed the CLA, thanks!

This file is kept alpha-sorted, if you could fix that up, then we can land this.

@chaporgin
Copy link
Copy Markdown
Contributor Author

fixed

Copy link
Copy Markdown
Collaborator

@OddBloke OddBloke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@OddBloke OddBloke merged commit ad23441 into canonical:master Jan 19, 2021
andrewbogott pushed a commit to andrewbogott/cloud-init that referenced this pull request Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants