Skip to content

stale: re-enable post holidays#749

Merged
OddBloke merged 2 commits into
canonical:masterfrom
OddBloke:stale
Jan 4, 2021
Merged

stale: re-enable post holidays#749
OddBloke merged 2 commits into
canonical:masterfrom
OddBloke:stale

Conversation

@OddBloke
Copy link
Copy Markdown
Collaborator

@OddBloke OddBloke commented Jan 4, 2021

Proposed Commit Message

stale: re-enable post holidays

This reverts commits fad919aa2c894abaa3af88aed1e064c1220937fe ("stale:
disable check for holiday break (#735)") and
e4f2d6139a802e659c571f581763eddeee715e2f ("stale: fix error in
definition (#740)").

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

This reverts commits fad919a ("stale:
disable check for holiday break (canonical#735)") and
e4f2d61 ("stale: fix error in
definition (canonical#740)").
Copy link
Copy Markdown
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Though we want to be sure before landing that the existing PRs that are stale won't just get closed on the next cron run.

@OddBloke OddBloke marked this pull request as ready for review January 4, 2021 22:19
@OddBloke
Copy link
Copy Markdown
Collaborator Author

OddBloke commented Jan 4, 2021

I've gone through and ensured that the only PRs that will get marked stale are those which are actually stale, so I've moved this to Ready to Review.

(I'll land it, and let it run normally: I'll check tomorrow that it hasn't done anything I wasn't expecting.)

@OddBloke OddBloke merged commit c5f6c78 into canonical:master Jan 4, 2021
@OddBloke OddBloke deleted the stale branch January 4, 2021 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants