Skip to content

Add example configuration for datasource AliYun#751

Merged
OddBloke merged 2 commits into
canonical:masterfrom
bittopaz:patch-1
Jan 7, 2021
Merged

Add example configuration for datasource AliYun#751
OddBloke merged 2 commits into
canonical:masterfrom
bittopaz:patch-1

Conversation

@bittopaz
Copy link
Copy Markdown
Contributor

@bittopaz bittopaz commented Jan 6, 2021

Proposed Commit Message

Add example configuration for datasource `AliYun`

Additional Context

Test Steps

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

Copy link
Copy Markdown
Collaborator

@OddBloke OddBloke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission, @bittopaz! I've left a few comments inline.

Comment thread doc/rtd/topics/datasources/aliyun.rst Outdated
Comment thread doc/rtd/topics/datasources/aliyun.rst Outdated
Comment thread doc/rtd/topics/datasources/aliyun.rst Outdated
Comment thread doc/rtd/topics/datasources/aliyun.rst Outdated
@bittopaz
Copy link
Copy Markdown
Contributor Author

bittopaz commented Jan 7, 2021

@OddBloke Thanks for taking time reviewing the changes. I have updated accordingly and rebased the commits.

Copy link
Copy Markdown
Collaborator

@OddBloke OddBloke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

(As this is a doc change only, we do not require CLA signature, so this is good to land.)

@OddBloke OddBloke self-assigned this Jan 7, 2021
@OddBloke OddBloke merged commit 30da21b into canonical:master Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants