Skip to content

Use more cloud defaults in integration tests#757

Merged
TheRealFalcon merged 4 commits into
canonical:masterfrom
TheRealFalcon:cloud-defaults
Jan 22, 2021
Merged

Use more cloud defaults in integration tests#757
TheRealFalcon merged 4 commits into
canonical:masterfrom
TheRealFalcon:cloud-defaults

Conversation

@TheRealFalcon
Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon commented Jan 8, 2021

Proposed Commit Message

Use more cloud defaults in integration tests

Stop requiring compartment_id for OCI and project_id for GCE since they
can now be inferred in pycloudlib.

Additional Context

n/a

Test Steps

Remove: GCE_PROJECT, GCE_REGION, GCE_ZONE, and OCI_COMPARTMENT_ID from user_settings.py if they exist there.
Run any integration test using GCE or OCI and it should pass.

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

@TheRealFalcon TheRealFalcon added the wip Work in progress, do not land label Jan 8, 2021
Stop requiring compartment_id for OCI and project_id for GCE since they
can no be inferred in pycloudlib.
@TheRealFalcon TheRealFalcon removed the wip Work in progress, do not land label Jan 20, 2021
@TheRealFalcon
Copy link
Copy Markdown
Contributor Author

@OddBloke Now that canonical/pycloudlib#87 is merged, this should work. I doubled checked by running both GCE and OCI runs without any cloud-specific details in my user_settings.py

Copy link
Copy Markdown
Collaborator

@OddBloke OddBloke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheRealFalcon TheRealFalcon merged commit 1527efa into canonical:master Jan 22, 2021
@TheRealFalcon TheRealFalcon deleted the cloud-defaults branch January 22, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants