Use more cloud defaults in integration tests#757
Merged
Conversation
9983c9e to
3a804aa
Compare
mitechie
approved these changes
Jan 12, 2021
Stop requiring compartment_id for OCI and project_id for GCE since they can no be inferred in pycloudlib.
1f7a84b to
d199e89
Compare
Contributor
Author
|
@OddBloke Now that canonical/pycloudlib#87 is merged, this should work. I doubled checked by running both GCE and OCI runs without any cloud-specific details in my user_settings.py |
This was referenced May 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
n/a
Test Steps
Remove: GCE_PROJECT, GCE_REGION, GCE_ZONE, and OCI_COMPARTMENT_ID from user_settings.py if they exist there.
Run any integration test using GCE or OCI and it should pass.
Checklist: