Fix regression by forcing no IMDS ssh keys#760
Merged
Conversation
OddBloke
reviewed
Jan 11, 2021
Collaborator
OddBloke
left a comment
There was a problem hiding this comment.
Thanks for this fix, Thomas! We'll need to discuss how to remediate this problem in a longer-term fashion, but this fix addresses our immediate need.
I have one important question inline: I want to make sure that the logging/diagnostics are aligned with your expectations. (I also have a side note, which doesn't really need addressing here.)
Collaborator
|
Thanks for the clarifications! I'm happy with this code. I'm now performing some testing locally, I will approve once I've confirmed this works. |
Contributor
Author
|
Thanks, @OddBloke! |
3 tasks
This was referenced May 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Fix regression with handling of IMDS ssh keys.
Checklist: