[VMware]:change default max wait time to 15s for better performance, …#774
Merged
TheRealFalcon merged 4 commits intoJan 27, 2021
Merged
Conversation
…modify documentation about how to change default value
Contributor
Author
|
Hi all, |
TheRealFalcon
approved these changes
Jan 27, 2021
Contributor
TheRealFalcon
left a comment
There was a problem hiding this comment.
I'm a little wary of changing default wait times as it could cause regressions for a small number of people, but since the setting is configurable and we've added documentation for the setting, I'm +1.
This was referenced May 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…modify documentation about how to change default value
summary: change default max wait time to 15s
If cloud-init is enabled on VMware platform, cloud-init will wait until its configuration file is ready and currently the max wait is 90 seconds by default. With our test, this configuration file should be ready within 1 second, so change it to 15 seconds for better performance. Also update the documentation about how to change the default value in cloud-init configuration file.
Checklist: