Skip to content

[VMware]:change default max wait time to 15s for better performance, …#774

Merged
TheRealFalcon merged 4 commits into
canonical:masterfrom
xiaofengw1205:xiaofengw-vmware-change-max-wait
Jan 27, 2021
Merged

[VMware]:change default max wait time to 15s for better performance, …#774
TheRealFalcon merged 4 commits into
canonical:masterfrom
xiaofengw1205:xiaofengw-vmware-change-max-wait

Conversation

@xiaofengw1205
Copy link
Copy Markdown
Contributor

…modify documentation about how to change default value

summary: change default max wait time to 15s

If cloud-init is enabled on VMware platform, cloud-init will wait until its configuration file is ready and currently the max wait is 90 seconds by default. With our test, this configuration file should be ready within 1 second, so change it to 15 seconds for better performance. Also update the documentation about how to change the default value in cloud-init configuration file.

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

@xiaofengw1205
Copy link
Copy Markdown
Contributor Author

Hi all,
Please help to review when you have time. Thanks a lot.

Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little wary of changing default wait times as it could cause regressions for a small number of people, but since the setting is configurable and we've added documentation for the setting, I'm +1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants