Skip to content

doc: avoid two warnings#781

Merged
TheRealFalcon merged 3 commits into
canonical:masterfrom
dankenigsberg:doc-avoid-morning
Jan 21, 2021
Merged

doc: avoid two warnings#781
TheRealFalcon merged 3 commits into
canonical:masterfrom
dankenigsberg:doc-avoid-morning

Conversation

@dankenigsberg
Copy link
Copy Markdown
Contributor

Two shell code blocks are not marked as such, confusing rst to consider
them as yaml. Be explicit about their syntax, and use $ prompt to match
elsewhere in the docs.

/home/travis/build/canonical/cloud-init/doc/rtd/topics/format.rst:28: WARNING: Could not lex literal_block as "yaml". Highlighting skipped.
/home/travis/build/canonical/cloud-init/doc/rtd/topics/format.rst:52: WARNING: Could not lex literal_block as "yaml". Highlighting skipped.

Signed-off-by: Dan Kenigsberg danken@redhat.com

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

Two shell code blocks are not marked as such, confusing rst to consider
them as yaml. Be explicit about their syntax, and use $ prompt to match
elsewhere in the docs.

/home/travis/build/canonical/cloud-init/doc/rtd/topics/format.rst:28: WARNING: Could not lex literal_block as "yaml". Highlighting skipped.
/home/travis/build/canonical/cloud-init/doc/rtd/topics/format.rst:52: WARNING: Could not lex literal_block as "yaml". Highlighting skipped.

Signed-off-by: Dan Kenigsberg <danken@redhat.com>
@TheRealFalcon
Copy link
Copy Markdown
Contributor

Hi @dankenigsberg , thanks for the contribution. Your change looks good. I noticed you signed our CLA, but after signing the CLA, you also need to add your Github username to tools/.github-cla-signers in order for our CLA signer check to pass. Once you do that we should be able to merge this.

@TheRealFalcon TheRealFalcon self-assigned this Jan 20, 2021
Comment thread tools/.github-cla-signers Outdated
Copying into git data that is maintained somewhere else sounds like an
inconsistency waiting to happen. Oh well.

Signed-off-by: Dan Kenigsberg <danken@redhat.com>
@TheRealFalcon
Copy link
Copy Markdown
Contributor

Thanks! We'll get this merged once CI passes.

@TheRealFalcon TheRealFalcon merged commit e051d54 into canonical:master Jan 21, 2021
andrewbogott pushed a commit to andrewbogott/cloud-init that referenced this pull request Jan 21, 2021
Two shell code blocks are not marked as such, confusing rst to consider
them as yaml. Be explicit about their syntax, and use $ prompt to match
elsewhere in the docs.

/home/travis/build/canonical/cloud-init/doc/rtd/topics/format.rst:28: WARNING: Could not lex literal_block as "yaml". Highlighting skipped.
/home/travis/build/canonical/cloud-init/doc/rtd/topics/format.rst:52: WARNING: Could not lex literal_block as "yaml". Highlighting skipped.

Signed-off-by: Dan Kenigsberg <danken@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants