Remove 'remove-raise-on-failure' calls from integration_tests#788
Merged
OddBloke merged 2 commits intoJan 26, 2021
Conversation
Pycloudlib no longer raises exceptions when cloud-init fails to start, and the API has been updated accordingly. Changes have been made to integration tests accordingly
OddBloke
suggested changes
Jan 25, 2021
Collaborator
OddBloke
left a comment
OddBloke
left a comment
There was a problem hiding this comment.
One docstring update needed (plus an unrelated observation). I'm going to test this locally before I Approve.
Comment on lines
62
to
64
| This wraps pycloudlib's `BaseInstance.restart` to pass | ||
| `raise_on_cloudinit_failure=False` to `BaseInstance.wait`, mirroring | ||
| our launch behaviour. |
| @@ -27,13 +27,13 @@ def _detect_reboot(instance: IntegrationInstance): | |||
| # detecting the first boot or second boot, so we also check | |||
| # the logs to ensure we've booted twice. If the logs show we've | |||
| # only booted once, wait until we've booted twice | |||
Collaborator
There was a problem hiding this comment.
Total aside, but I just noticed that this test could fail (by exiting early) if run on an instance which has booted more than once without cloud-init.log removal: the "first" boot would have multiple entries. Generally for this sort of check, I think we need a "before" count which is expected to increase before we consider the reboot complete (and this is why we should capture this in library code, so every .restart() call DTRT).
Anyway, moving on.
Collaborator
|
Tested this locally so LGTM; +1 once the docstring update happens. |
This was referenced May 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pycloudlib no longer raises exceptions when cloud-init fails to start,
and the API has been updated accordingly. Changes have been made to
integration tests accordingly
Proposed Commit Message
Additional Context
canonical/pycloudlib#93
Test Steps
Tested on both lxd containers and lxd vms. Failures were unrelated.
Checklist: