Skip to content

Stop linting cloud_tests#791

Merged
TheRealFalcon merged 2 commits into
canonical:masterfrom
TheRealFalcon:pylint
Jan 26, 2021
Merged

Stop linting cloud_tests#791
TheRealFalcon merged 2 commits into
canonical:masterfrom
TheRealFalcon:pylint

Conversation

@TheRealFalcon
Copy link
Copy Markdown
Contributor

Proposed Commit Message

Stop linting cloud_tests

The tox pylint command was failing because of competing dependencies in
the multiple requirements files. Given that we plan on no longer
updating cloud_tests, we also no longer need to lint them.

Additional Context

n/a

Test Steps

tox -e pylint in a bionic container

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

Copy link
Copy Markdown
Collaborator

@OddBloke OddBloke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed locally this addresses the issue. Thanks!

@OddBloke
Copy link
Copy Markdown
Collaborator

Oh, I just realised that we should do the same for the tip-pylint env.

The tox pylint command was failing because of competing dependencies in
the multiple requirements files. Given that we plan on no longer
updating cloud_tests, we also no longer need to lint them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants