Port apt cloud_tests to integration tests#808
Merged
Conversation
blackboxsw
approved these changes
Feb 16, 2021
Collaborator
blackboxsw
left a comment
There was a problem hiding this comment.
Looks good, I appreciate reducing and consolidating the test cases anywhere we have the ability to test non-conflicting features. Integration tests are too time/CPU costly for setup/teardown to not leverage some of that setup for multiple tests where applicable. Even in the test/cloud_tests we talked about trying to combine some tests that would not be destructive for other feature tests. Expedite test where we can and where it doesn't cause us problems in terms of getting a valid signal on a test failure.
Co-authored-by: Chad Smith <chad.smith@canonical.com>
This was referenced May 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Port apt cloud_tests to integration tests
Additional Context
This should cover all of the apt_*.py test cases currently in the cloud tests. I ported things as close to 1:1 as possible, but added some different PPA sources to ensure a source from one test wasn't affected a check in another.
I also question the value of a couple of these tests. In particular, the ones under
TestDefaults, and wondering if we need 3 different tests for what's intest_key,test_keyserver, andtest_ppa. I think it's fine to keep them, but if reviewers have strong opinions on deleting anything, let me know.Test Steps
pytest tests/integration_tests/modules/test_apt.py
Checklist: