integration_tests: fix test_gh626 on LXD VMs via SSH#809
Merged
Conversation
Without a MAC address match clause, the test network configuration is not applied to the primary interface in LXD VMs (which is named enp*s* rather than eth0).
Collaborator
Author
|
This test has the same bug that all other tests which are setting a MAC address do: it uses the same MAC address everywhere, so if instances from previous runs are around or tests are being run in parallel, failures will be observed due to traffic being routed to the "wrong" I'll address that generally in a follow-up. |
TheRealFalcon
approved these changes
Feb 16, 2021
This was referenced May 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Test Steps
Run the test on a LXD VM (with either an SSH key configured, or with the new pycloudlib which uses SSH by default) and observe success.
Checklist: