integration_tests: use unique MAC addresses for tests#813
Merged
Conversation
TheRealFalcon
approved these changes
Feb 18, 2021
Contributor
TheRealFalcon
left a comment
There was a problem hiding this comment.
Funny thing is I slightly prefer util.py to __init__.py. __init__.py has always seemed more "hidden" to me. But still +1 😄
Contributor
|
Did we turn up a setting on pylint? The pylint issues don't seem related to what you've changed. |
Collaborator
Author
I suspect that adding |
Using the same MAC address results in strange test behaviour if more than one such instance is up: traffic gets routed to an arbitrary interface with the given MAC address. This can happen if running tests in parallel, or on a system which retains test instances from previous runs. The introduction of tests/integration_tests/__init__.py means that pylint now checks the integration tests: this commit also addresses those failures.
This was referenced May 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Info
This introduces
tests/integration_tests/__init__.pyas a holding place for the utility function this introduces; I didn't want to introduce autil, but it also didn't feel like it fit well in anything we currently had.Test Steps
Run the affected tests in parallel a few times and observe a lack of collisions.
Checklist: