bringup_static_routes: fix gateway check#850
Merged
TheRealFalcon merged 2 commits intoApr 7, 2021
Merged
Conversation
giggsoff
force-pushed
the
bringup_static_routes_fix
branch
2 times, most recently
from
94157f8 to
3aab8e4
Compare
Contributor
Author
|
I sigend the CLA, but cannot pass CI |
giggsoff
force-pushed
the
bringup_static_routes_fix
branch
from
3aab8e4 to
c63cfd5
Compare
Inside gateway field we has ip address not in CIDR notation. We must check it because of different ip route behavior for gatewayed and direct routes. Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com>
TheRealFalcon
force-pushed
the
bringup_static_routes_fix
branch
from
c63cfd5 to
c44a198
Compare
TheRealFalcon
approved these changes
Apr 7, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Test Steps
Try to run cloud-init with classless-static-routes with direct-connection of networks give me errors lf-edge/eve#1982 (comment).
Checklist: