Skip to content

Azure: mount the default provisioning iso location before attempting to find it through device listing#870

Merged
TheRealFalcon merged 6 commits into
canonical:mainfrom
anhvoms:anhvo/fasterProvisioningIsoDetection
Jul 19, 2021
Merged

Azure: mount the default provisioning iso location before attempting to find it through device listing#870
TheRealFalcon merged 6 commits into
canonical:mainfrom
anhvoms:anhvo/fasterProvisioningIsoDetection

Conversation

@anhvoms
Copy link
Copy Markdown
Contributor

@anhvoms anhvoms commented Apr 16, 2021

Proposed Commit Message

Mount the default provisioning iso location before attempting to find it through device listing

With a few exceptions, Azure VM deployments receive provisioning metadata 
through the provisioning iso presented as a cdrom device (/dev/sr0).
The existing code attempts to find this device by calling blkid to find all devices
that have either type iso9660 or udf. This can be very expensive if the VM has
a lot of disks. This commit will attempt to mount the default iso location 
first and only tries to use blkid to locate the iso location if the default mounting
location fails

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

Comment thread cloudinit/sources/DataSourceAzure.py Outdated
@anhvoms anhvoms requested a review from OddBloke May 5, 2021 15:39
Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anhvoms , your changes here look good. I left a few nits inline, but nothing major.

There's a conflict now with master. Can you rebase the PR and then we should be able to get this merged soon.

Comment thread cloudinit/sources/DataSourceAzure.py Outdated
Comment thread cloudinit/sources/DataSourceAzure.py Outdated
Comment thread cloudinit/sources/DataSourceAzure.py Outdated
@TheRealFalcon TheRealFalcon self-assigned this May 21, 2021
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 5, 2021

Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close.

If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging mitechie, and he will ensure that someone takes a look soon.

(If the pull request is closed and you would like to continue working on it, please do tag mitechie to reopen it.)

@github-actions github-actions Bot added the stale-pr Pull request is stale; will be auto-closed soon label Jun 5, 2021
@mitechie mitechie removed the stale-pr Pull request is stale; will be auto-closed soon label Jun 7, 2021
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 2, 2021

Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close.

If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging mitechie, and he will ensure that someone takes a look soon.

(If the pull request is closed and you would like to continue working on it, please do tag mitechie to reopen it.)

@github-actions github-actions Bot added the stale-pr Pull request is stale; will be auto-closed soon label Jul 2, 2021
@TheRealFalcon TheRealFalcon removed the stale-pr Pull request is stale; will be auto-closed soon label Jul 6, 2021
@TheRealFalcon TheRealFalcon merged commit a984ee7 into canonical:main Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants