Skip to content

cc_disk_setup.py: remove UDEVADM_CMD definition as not used#886

Merged
TheRealFalcon merged 2 commits into
canonical:masterfrom
dermotbradley:cc_disk_setup-remove-udevadm-refs
May 8, 2021
Merged

cc_disk_setup.py: remove UDEVADM_CMD definition as not used#886
TheRealFalcon merged 2 commits into
canonical:masterfrom
dermotbradley:cc_disk_setup-remove-udevadm-refs

Conversation

@dermotbradley
Copy link
Copy Markdown
Contributor

Proposed Commit Message

cc_disk_setup.py: remove UDEVADM_CMD definition as not used

UDEVADM_CMD is defined but not actually used in cc_disk_setup.py
so remove it.

Also modify the comment at top of read_parttbl function to remove the
reference to udevadm which implies it is used to scan the partition table.

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

UDEVADM_CMD is defined but not actually used in cc_disk_setup.py
so remove it.

Also modify the comment at top of read_parttbl function to remove the
reference to udevadm which implies it is used to scan the partition table.
Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheRealFalcon TheRealFalcon merged commit 77320bf into canonical:master May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants