BSD: static network, set the mtu#894
Merged
TheRealFalcon merged 2 commits intoMay 14, 2021
Merged
Conversation
TheRealFalcon
suggested changes
May 10, 2021
Contributor
TheRealFalcon
left a comment
TheRealFalcon
left a comment
There was a problem hiding this comment.
Thanks @goneri . Overall, the changes make sense. However, we're still supporting python 3.5 which doesn't support f-strings yet, so the Travis build is failing. Additionally, you have a flake8 issue you missed. Can you fix up the f-string and flake8 issue?
Contributor
Author
|
Hi @TheRealFalcon, thanks for the feedback. I will adjust that. |
goneri
force-pushed
the
BSD-static-network-set-the-mtu_13881
branch
from
7ce75b2 to
801fdd6
Compare
goneri
force-pushed
the
BSD-static-network-set-the-mtu_13881
branch
from
801fdd6 to
c23e1e9
Compare
In the case of a static network, we now set the MTU according to the meta-data.
goneri
force-pushed
the
BSD-static-network-set-the-mtu_13881
branch
from
c23e1e9 to
061e2f1
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case of a static network, we now set the MTU according to the
meta-data.