Skip to content

Add integration test for #868 #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blackboxsw merged 2 commits into from
May 19, 2021
Merged

Add integration test for #868 #901

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
806eb1e
Add integration test for #868
TheRealFalcon May 11, 2021
0888b65
Merge branch 'master' into chef-test
blackboxsw May 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions tests/integration_tests/bugs/test_gh868.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
"""Ensure no Traceback when 'chef_license' is set"""
import pytest
from tests.integration_tests.instances import IntegrationInstance


USERDATA = """\
#cloud-config
chef:
install_type: omnibus
Copy link
Copy Markdown
Contributor Author

@TheRealFalcon TheRealFalcon May 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any concerns about this being in an integration test? This causes chef to install from https://www.chef.io/chef/install.sh

Copy link
Copy Markdown
Collaborator

@blackboxsw blackboxsw May 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this test because it tests a realworld application/use-case all the way to the source.

All good to have the remote script source. I don't mind this for two reasons:

  • security: not concerned as it's a short-lived instance that is torn down immediately after the test run
  • scripts on the internet changing which break our tests: let's deal/cope with that only if we find that this test is really flaky due to changes in the script.

Are there other concerns you had in mind?

Copy link
Copy Markdown
Contributor Author

@TheRealFalcon TheRealFalcon May 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just from a "good steward" point of view, but I can't image our jenkins runs would be more than a blip compared to the number of hits it receives.

Only reason I thought of it was because we have an older cloud test for chef that is disabled because it relies on a 3rd party repo. https://github.com/canonical/cloud-init/blob/master/tests/cloud_tests/testcases/examples/install_run_chef_recipes.yaml#L4

Copy link
Copy Markdown
Collaborator

@blackboxsw blackboxsw May 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with us keeping this for now. That commit where we disabled was pointing to https://bugs.launchpad.net/cloud-init/+bug/1678145 which was basically a "don't let things on the internet break us when they change". If this ends up breaking repeatedly and causing maintenance problems, We can spend time to remedy/cache it or something else.

chef_license: accept
server_url: https://chef.yourorg.invalid
validation_name: some-validator
"""


@pytest.mark.user_data(USERDATA)
def test_chef_license(client: IntegrationInstance):
log = client.read_from_file('/var/log/cloud-init.log')
assert 'Traceback' not in log