openbsd/net: flush the route table on net restart#908
Merged
TheRealFalcon merged 1 commit intoMay 25, 2021
Merged
Conversation
TheRealFalcon
suggested changes
May 24, 2021
Contributor
TheRealFalcon
left a comment
TheRealFalcon
left a comment
There was a problem hiding this comment.
Looks good, but we need to fix the flake8 errors.
Comment on lines
+39
to
+41
| subp.subp(['pkill', 'dhclient'], capture=True, rcs=[0 ,1]) | ||
| subp.subp(['route', 'del', 'default'], capture=True, rcs=[0 ,1]) | ||
| subp.subp(['route', 'flush', 'default'], capture=True, rcs=[0 ,1]) |
Contributor
There was a problem hiding this comment.
Suggested change
| subp.subp(['pkill', 'dhclient'], capture=True, rcs=[0 ,1]) | |
| subp.subp(['route', 'del', 'default'], capture=True, rcs=[0 ,1]) | |
| subp.subp(['route', 'flush', 'default'], capture=True, rcs=[0 ,1]) | |
| subp.subp(['pkill', 'dhclient'], capture=True, rcs=[0, 1]) | |
| subp.subp(['route', 'del', 'default'], capture=True, rcs=[0, 1]) | |
| subp.subp(['route', 'flush', 'default'], capture=True, rcs=[0, 1]) |
Ensure we've got a clean environment before we restart the network. In some cases, the `sh /etc/netstart` is not enough to restart the network. A previous default route remains in the route table and as a result the network is broken. Also `sh /netstart` does not kill `dhclient`. The problen happens for instance with OVH OpenStack SBG3.
goneri
force-pushed
the
openbsd-net-flush-the-route-table-on-net-restart_15259
branch
from
6e2e2da to
8baa9fb
Compare
TheRealFalcon
approved these changes
May 25, 2021
Contributor
Author
|
Thank you @TheRealFalcon. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure we've got a clean environment before we restart the network.
In some cases, the
sh /etc/netstartis not enough to restart thenetwork. A previous default route remains in the route table and
as a result the network is broken.
Also
sh /netstartdoes not killdhclient.The problen happens for instance with OVH OpenStack SBG3.