testing: OCI availability domain is now required (SC-59)#910
Merged
blackboxsw merged 3 commits intoJun 15, 2021
Conversation
|
Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close. If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging mitechie, and he will ensure that someone takes a look soon. (If the pull request is closed and you would like to continue working on it, please do tag mitechie to reopen it.) |
github-actions
Bot
added
the
stale-pr
TheRealFalcon
removed
the
stale-pr
TheRealFalcon
force-pushed
the
oci-availability-domain
branch
from
47fe51d to
dfd3305
Compare
TheRealFalcon
force-pushed
the
oci-availability-domain
branch
from
dfd3305 to
f97ab68
Compare
blackboxsw
approved these changes
Jun 15, 2021
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
src commitish good and thx for the comment.
| # OCI SETTINGS | ||
| ################################################################## | ||
| # Availability domain to use for Oracle. Should be one of the namess found | ||
| # in `oci iam availability-domain list` |
Collaborator
There was a problem hiding this comment.
Thanks for this comment, future me will need it.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
See canonical/pycloudlib#138 and canonical/pycloudlib#147
Test Steps
Specify 'oci' as your integration testing
PLATFORM. If you don't setORACLE_AVAILABILITY_DOMAIN, the test exit with an exception that it is required. WhenORACLE_AVAILABILITY_DOMAINis specified, the tests should run as expected.Checklist: