Small Doc Update for ReportEventStack and Test#920
Conversation
- small document update for ReportEventStack explaining post_files parameter - small unit test for test_reporting demonstrating the close of an event with optional post_files list Resolves: docs/reporting-events-doc-update-and-test
|
Also, not entirely sure how to tie Launchpad stuff to GitHub, but for-what-its-worth, I do have a Launchpad account here: |
|
Hey @irishgordo , thanks for this change! In order to accept your change, you need to sign the CLA and add your Github username (alphabetically) to the cla signers file . The full details are described in the last bullet point here: https://cloudinit.readthedocs.io/en/latest/topics/hacking.html#submitting-your-first-pull-request You don't need to worry about the launchpad stuff. |
- added irishgordo GitHub UserName alphabetically to CLA Signers Resolves: docs/reporting-events-doc-update-and-test
|
@TheRealFalcon Glad I could help, I'm super game to make any adjustments if needed as well with the additional test or doc update too. Thanks again for the quick response and the approval! |
Proposed Commit Message
parameter
event with optional post_files list
Summary
Hey there, this project is rad! Trying to wrap my head around bits of it here and there, very greenhorn still haha. Thought there might be a slight benefit to a little more documentation surrounding an optional list parameter. Added an additional little test for small additional gain of test coverage and demonstration.
Checklist: