Skip to content

Replace deprecated collections.Iterable with abc replacement (SC-127)#922

Merged
blackboxsw merged 1 commit into
canonical:masterfrom
TheRealFalcon:deprecated-collections
Jun 15, 2021
Merged

Replace deprecated collections.Iterable with abc replacement (SC-127)#922
blackboxsw merged 1 commit into
canonical:masterfrom
TheRealFalcon:deprecated-collections

Conversation

@TheRealFalcon
Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon commented Jun 15, 2021

Proposed Commit Message

Replace deprecated collections.Iterable with abc replacement

LP: #1932048

Additional Context

Deprecated since version 3.3, will be removed in version 3.10: Moved Collections Abstract Base Classes to the collections.abc module. For backwards compatibility, they continue to be visible in this module through Python 3.9.

https://docs.python.org/3.9/library/collections.html

I did a quick search for any other references to something in collections that should be coming from collections.abc and didn't find anything.

Test Steps

n/a

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

@TheRealFalcon TheRealFalcon changed the title Replace deprecated collections.Iterable with abc replacement Replace deprecated collections.Iterable with abc replacement (SC-127) Jun 15, 2021
@TheRealFalcon TheRealFalcon requested a review from blackboxsw June 15, 2021 17:34
Copy link
Copy Markdown
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve only python3.5 support needed for collections.abc. No need to support earlier per https://lists.launchpad.net/cloud-init/msg00336.html

@blackboxsw blackboxsw merged commit 950c186 into canonical:master Jun 15, 2021
@TheRealFalcon TheRealFalcon deleted the deprecated-collections branch March 21, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants