VMware: add a new switch allow_raw_data to control raw data feature#939
Merged
TheRealFalcon merged 2 commits intoJul 8, 2021
Conversation
…update the documentation. Fix bugs about max_wait.
TheRealFalcon
approved these changes
Jul 7, 2021
Contributor
TheRealFalcon
left a comment
TheRealFalcon
left a comment
There was a problem hiding this comment.
One nit inline.
Also, it might be time to start breaking up _get_data into smaller methods. I don't think it's necessary for this PR, but going through the layers of nesting is getting hard to read.
Contributor
Author
Thanks, I agree with you. It needs a full test and I prefer to do it in another pull request. I have created an internal PR to address this. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…update the documentation. Fix bugs about max_wait.
summary: Introduce a new switch allow_raw_data to control raw data feature, its default value is true. Also fix bugs about max_wait. Update the documentation accordingly.
Test Steps
Set allow_raw_data to True and False in datasource config, trigger the guest customization on VMware vsphere and verify cloud-init could get the execpted data source.
Checklist: