Update pylint and fix the new issues its spots

[paride]

Proposed Commit Message

Update pylint to v2.9.3 and fix the new issues its spots

In CI run against pylint 2.9.3 and fix occurrences of:
 - W0237 (arguments-renamed)
 - W0402 (deprecated-module)

The W0402 deprecated-module was about module `imp`:

    cloudinit/patcher.py:9: [W0402(deprecated-module), ]
        Uses of a deprecated module 'imp'

The imp module is deprecated and replaced by importlib, which according
to the documentation has no replacement for acquire_lock() and
release_lock(), which are the only reason why `imp` is imported.
    
I see nothing about the code using this lock that actually requires it.
Let's remove the locking code and the import altogether.

Dropping the locking makes patcher.patch() an empty wrapper around
_patch_logging(). Rename _patch_logging() to patch_logging() and
call it directly instead. Drop patch().

Additional Context

Spotted by our cloud-init-style-tip Jenkins job.

This is the job always running against the latest versions of the linters. The job allows to keep the code up-to-date with the new versions without breaking CI, which uses pinned versions instead.

Test Steps

Checklist:

• My code follows the process laid out in the documentation
• I have updated or added any unit tests accordingly
• I have updated or added any documentation accordingly

[paride]

This is marked as a WIP because it doesn't fix this yet:

cloudinit/patcher.py:9: [W0402(deprecated-module), ] Uses of a deprecated module 'imp'

as I'm not really sure on what to do. The imp module is deprecated and replaced by importlib, which according to the documentation has no replacement for acquire_lock() and release_lock(). I'm not sure if those calls are still needed, or if we should silence the warning for now.

Other projects are facing this, e.g. pypa/setuptools#479

[paride]

CI failure is of course expected for now:

cloudinit/patcher.py:9: [W0402(deprecated-module), ] Uses of a deprecated module 'imp'

[TheRealFalcon]

The imp module is deprecated and replaced by importlib, which according to the documentation has no replacement for acquire_lock() and release_lock(). I'm not sure if those calls are still needed, or if we should silence the warning for now.

I see nothing about the code using this lock that actually requires it. There's not multiple threads in play and we're not creating import hooks. I'm comfortable removing the locking code altogether.

[paride]

Thanks! I agree it doesn't really seem needed. I'll update the branch and drop those.

[paride]

Branch updated and proposed commit message updated. I removed the WIP as this is now ready for review.

[TheRealFalcon]

Some minor requests inline

[paride]

PR updated and proposed commit message also updated.

[TheRealFalcon]

Thanks!