Summary: Add 'network-config' support in ovf-env.xml through VMware g…#947
Conversation
…uestinfo.ovfEnv Details: 1. Support guest set network config through guestinfo.ovfEnv using OVF 2. 'network-config' Property is optional 3. 'network-config' Property's value has to be base64 encoded Added unittests and updated ovf-env.xml example
| break | ||
| if contents: | ||
| (md, ud, cfg) = read_ovf_environment(contents) | ||
| read_network = ('com.vmware.guestinfo' == name) |
There was a problem hiding this comment.
Should this not have been com.vmware.guestInfo (different capitalization) the same as in line 353 above?
There was a problem hiding this comment.
Also why is this not supposed to work with the ISO transport?
There was a problem hiding this comment.
@t-8ch Thanks for catching this. I should add more tests on this change. Will file a PR to fix it and add tests.
There was a problem hiding this comment.
@t-8ch For ISO transport, It can be supported, but user need create ISO for each instance with specified network configuration, I don't see it's a common user case when I opened this PR.
And com.vmware.guestInfo is VMware platform specified, I get this request from inside of VMware, the guestinfo.ovfEnv can be updated easily from outside of instance(vm).
There was a problem hiding this comment.
Would not VMware itself be able to generate the ISO on demand, at least when specifying the ISO transport in VMware?
There was a problem hiding this comment.
Yes, AFAIK, ISO can be generated on demand on VMware platform, till now, network config is never included in such ISO. The ISO transport is not VMware specified, if there is indeed such requirement, I can make the change and let cloud-init team review it.
There was a problem hiding this comment.
@PengpengSun Thanks for your patch!
Personally I would like to see the network-config also be supported via the ISO.
It should not necessarily change more oftern than the user-data .
Also the ISO transport is defined directly by the upstream DMTF standard.
(See https://www.dmtf.org/sites/default/files/standards/documents/DSP0243_2.1.1.pdf , 11.2 Transport media type)
If you prefer I can also send a patch.
There was a problem hiding this comment.
@t-8ch Please fell free to send the patch, I was hesitating to add ISO transport because it's not specified to VMware platform. Let's see if cloud-init team is ok with it too.
3 participants
…uestinfo.ovfEnv
Details:
Added unittests and updated ovf-env.xml example
Test Steps
Checklist: