Azure: Limit polling network metadata on connection errors

[aswinrajamannar]

Proposed Commit Message

Azure: Limit polling network metadata on connection errors

Description

This is a follow up to #878 where we currently limit polling on network metadata to 10 retries if the calls fail due to timeout errors. After enabling the feature in Azure, we noticed that if secondary nic is attached first, the calls could also fail with network unreachable ConnectionError. In these cases as well, we shouldn't poll indefinitely, and instead move on to listen for more nic attach events.

Test Steps

• Deploy a multi-nic VM in Azure that goes through the nic hot-attach code path. In a few cases where the secondary nic is attached first, the VM deployment might fail if this fix is missing.

Checklist:

• My code follows the process laid out in the documentation
• I have updated or added any unit tests accordingly
• I have updated or added any documentation accordingly

[TheRealFalcon]

Looks good to me! I left two nit suggestions inline.

[aswinrajamannar]

Looks good to me! I left two nit suggestions inline.

Thanks. Committed the suggestions.