cc_resolv_conf: fix typos

[sshedi]

No description provided.

[sshedi]

@TheRealFalcon can we add a test to this? I have no idea how it sneaked in.

[TheRealFalcon]

Ooph, thanks for the changes and the test here. Some of our modules still lack test coverage, and this particular one makes that very apparent.

One nit on the added test: It would be easier to read and help fix any potential failures if we had 5 separate tests, rather than checking the 5 conditions in one larger test. I won't block the PR on it, but it'd be a helpful small change.

Before I merge this, does photon need an update too? On the line I linked to, I noticed the key is resolv_conf_fn, but networkd.py is looking for resolved_conf_fn. Should that be updated too?

[sshedi]

Ooph, thanks for the changes and the test here. Some of our modules still lack test coverage, and this particular one makes that very apparent.

One nit on the added test: It would be easier to read and help fix any potential failures if we had 5 separate tests, rather than checking the 5 conditions in one larger test. I won't block the PR on it, but it'd be a helpful small change.

Before I merge this, does photon need an update too? On the line I linked to, I noticed the key is resolv_conf_fn, but networkd.py is looking for resolved_conf_fn. Should that be updated too?

Oops. I will fix it. Also break the test into separate tests. Need sometime, I'm caught up with some other task. Is that okay?

[TheRealFalcon]

Yep, no rush!