Replace broken httpretty tests with mock (SC-324)#973
Merged
Conversation
Certain versions of python/httpretty don't work correctly using https URIs. canonical#960 recently added httpretty tests using https. This commit replaces the httpretty tests that were failing on https with mocks of readurl instead.
TheRealFalcon
changed the title
paride
approved these changes
Aug 12, 2021
Contributor
paride
left a comment
paride
left a comment
There was a problem hiding this comment.
The code LGTM and I verified that the tests pass with this merged.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
This was found by running
packages/bddebon main.The root cause has been open for 6 years now (and has affected other parts of the code base), so we may want to migrate to responses at some point in the future.
Test Steps
Checklist: