Skip to content

Revert unnecesary lcase in ds-identify#978

Merged
TheRealFalcon merged 1 commit into
canonical:mainfrom
akutz:revert-lcase-optimization-in-dscheck
Aug 13, 2021
Merged

Revert unnecesary lcase in ds-identify#978
TheRealFalcon merged 1 commit into
canonical:mainfrom
akutz:revert-lcase-optimization-in-dscheck

Conversation

@akutz
Copy link
Copy Markdown
Contributor

@akutz akutz commented Aug 13, 2021

Proposed Commit Message

Revert unnecesary lcase in ds-identify

This patch reverts an unnecessary lcase optimization in the
ds-identify script. SystemD documents the values produced by
the systemd-detect-virt command are lower case, and the mapping
table used by the FreeBSD check is also lower-case.

The optimization added two new forked processes, needlessly
causing overhead.

Additional Context

Please see #970 (comment) for more information.

cc @smoser

Test Steps

$ make clean_pyc && PYTHONPATH="$(pwd)" python3 -m pytest -v tests/unittests/test_ds_identify.py

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

This patch reverts an unnecessary lcase optimization in the
ds-identify script. SystemD documents the values produced by
the systemd-detect-virt command are lower case, and the mapping
table used by the FreeBSD check is also lower-case.

The optimization added two new forked processes, needlessly
causing overhead.
@akutz akutz mentioned this pull request Aug 13, 2021
3 tasks
@TheRealFalcon TheRealFalcon merged commit f516a7d into canonical:main Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants