Skip to content

testing: skip upgrade tests on LXD VMs #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blackboxsw merged 2 commits into from
Aug 14, 2021
+10 −1
Merged

testing: skip upgrade tests on LXD VMs #980

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad59571
testing: skip upgrade tests on LXD VMs
TheRealFalcon Aug 10, 2021
6d0a47d
Merge branch 'main' into test-hostname-bionic
blackboxsw Aug 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion tests/integration_tests/test_upgrade.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import os
import pytest

from tests.integration_tests.clouds import IntegrationCloud
from tests.integration_tests.clouds import ImageSpecification, IntegrationCloud
from tests.integration_tests.conftest import get_validated_source


Expand Down Expand Up @@ -45,6 +45,15 @@ def test_clean_boot_of_upgraded_package(session_cloud: IntegrationCloud):
if not source.installs_new_version():
pytest.skip(UNSUPPORTED_INSTALL_METHOD_MSG.format(source))
return # type checking doesn't understand that skip raises
if (ImageSpecification.from_os_image().release == 'bionic' and
session_cloud.settings.PLATFORM == 'lxd_vm'):
# The issues that we see on Bionic VMs don't appear anywhere
# else, including when calling KVM directly. It likely has to
# do with the extra lxd-agent setup happening on bionic.
# Given that we still have Bionic covered on all other platforms,
# the risk of skipping bionic here seems low enough.
pytest.skip("Upgrade test doesn't run on LXD VMs and bionic")
return

launch_kwargs = {
'image_id': session_cloud.released_image_id,
Expand Down