Add integration test for sensitive jinja substitution (SC-352)#986
Merged
TheRealFalcon merged 1 commit intoAug 20, 2021
Merged
Conversation
TheRealFalcon
changed the title
blackboxsw
approved these changes
Aug 19, 2021
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
LGTM. good drop. No need to double test and the jinja var subst covers both basic runcmd ++ jinja var substitution.
Ensure jinja templates work for both instance-data.json and instance-data-sensitive.json. Test for LP: #1931392 Also removed test_runcmd.py as it's made redundant by this change.
TheRealFalcon
force-pushed
the
sensitive-substitution
branch
from
ee7a083 to
ef281ac
Compare
This was referenced May 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
https://bugs.launchpad.net/cloud-init/+bug/1931392 and #917
Test Steps
pytest tests/integration_tests/modules/test_combined.py
Checklist: