Skip to content

testing: Fix ssh keys integration test#992

Merged
blackboxsw merged 4 commits into
canonical:mainfrom
TheRealFalcon:fix-ssh-test
Aug 23, 2021
Merged

testing: Fix ssh keys integration test#992
blackboxsw merged 4 commits into
canonical:mainfrom
TheRealFalcon:fix-ssh-test

Conversation

@TheRealFalcon
Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon commented Aug 23, 2021

Proposed Commit Message

testing: Fix ssh keys integration test

Home directory permissions changed in hirsute. The integration test
assumed permissions from earlier releases. Test was fixed to take both
permissions into account

Additional Context

Test Steps

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

Home directory permissions changed in hirsute. The integration test
assumed permissions from earlier releases. Test was fixed to take both
permissions into account
Comment thread tests/integration_tests/modules/test_ssh_keysfile.py Outdated
TheRealFalcon and others added 2 commits August 23, 2021 14:46
Copy link
Copy Markdown
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since this test is "@ubuntu" only we can make this kind of conditional check work for this test. if CI passes let's land it.

@blackboxsw blackboxsw merged commit 6803368 into canonical:main Aug 23, 2021
@TheRealFalcon TheRealFalcon deleted the fix-ssh-test branch August 23, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants