Skip to content

Conversation

@dimaqq
Copy link
Contributor

@dimaqq dimaqq commented Jul 30, 2025

Applicable spec: a separate clean up PR before adding the "protocol" field per ISD240.

Overview

Update the example in the doc string to the actual arguments of the requirer.

Rationale

Juju Events Changes

none

Module Changes

none

Library Changes

doc fix in haproxy-route

Checklist

@github-actions
Copy link
Contributor

Test results for commit 10a5c10

Test coverage for 10a5c10

Name                                     Stmts   Miss Branch BrPart  Cover   Missing
------------------------------------------------------------------------------------
lib/charms/haproxy/v1/haproxy_route.py     340     55     78     24    79%   171, 174, 222, 231-234, 259-262, 283-288, 569-570, 713-716, 720, 746-757, 782-784, 803-805, 814, 966-972, 976, 1149->1151, 1153->1155, 1155->1157, 1157->1159, 1159->1161, 1161->1164, 1196, 1201, 1206, 1231, 1259, 1263, 1267, 1290, 1311, 1321-1322, 1324->exit, 1360-1362, 1382, 1396, 1401-1403
src/charm.py                               221     79     64      7    56%   82, 178, 186-199, 204, 209, 225, 236, 242-243, 271-291, 310-326, 386-399, 412-417, 426, 438-452, 457, 467, 473-479, 489-495
src/haproxy.py                              94     37      2      0    59%   95, 104-110, 128-142, 155-164, 172-179, 188-197, 206-212, 220-229, 257, 281-283
src/http_interface.py                       73     25      4      0    62%   74, 83, 92, 106-108, 126, 138, 150, 162, 170-175, 187, 194, 202, 217-227
src/state/charm_state.py                    72     15     14      4    78%   89-91, 96-97, 100, 137-142, 151, 193-195, 207-208
src/state/exception.py                       1      0      0      0   100%
src/state/ha.py                             30      1      2      1    94%   50
src/state/haproxy_route.py                 105     19     28      5    76%   100, 114-117, 131-135, 149-157, 211, 221-222, 253, 261
src/state/ingress.py                        35      0      4      0   100%
src/state/ingress_per_unit.py               31      0      4      0   100%
src/state/tls.py                            38      5     10      3    83%   76, 114-119, 125-126
src/state/validation.py                     46     23      8      1    44%   66-67, 71-98
src/tls_relation.py                         43      5     12      4    84%   73-74, 76->75, 99-105, 117->119
------------------------------------------------------------------------------------
TOTAL                                     1129    264    230     49    72%

Static code analysis report

Run started:2025-07-30 09:45:27.773816

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 4153
  Total lines skipped (#nosec): 4
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 3

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@dimaqq dimaqq merged commit e0d47cb into canonical:main Jul 31, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants