Skip to content

Conversation

@dwilding
Copy link
Contributor

@dwilding dwilding commented Dec 3, 2025

This PR updates how tox is installed in the GitHub CI examples in our docs. The latest machine and Kubernetes Charmcraft profiles expect uv, tox, and tox-uv, so I figure it's good for our docs to show that too.

Unlike in our own CI, I've not pinned the uv action to a specific commit. Should we mention something about this in the docs?

Copilot AI review requested due to automatic review settings December 3, 2025 10:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the CI examples in the documentation by replacing the traditional pip install tox approach with uv and tox-uv tooling. This aligns the documentation with the latest machine and Kubernetes Charmcraft profiles that expect these tools to be used.

Key changes:

  • Updates Python setup action from v5 to v6
  • Introduces astral-sh/setup-uv action for uv installation
  • Replaces pip-based tox installation with uv tool install tox --with tox-uv

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
docs/howto/write-and-structure-charm-code.md Updates three CI workflow examples (lint, unit tests, integration tests) to use uv and tox-uv
docs/explanation/testing.md Updates unit test CI example to use uv and tox-uv, adds missing Python setup step

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dwilding dwilding merged commit db54c23 into canonical:main Dec 4, 2025
55 of 56 checks passed
@dwilding dwilding deleted the pip-to-uv branch December 4, 2025 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants