fix: replace git reference injection with wheel artifacts in charm test workflows #2252

Copilot · 2025-12-19T03:00:02Z

Original prompt

This section details on the original issue you should resolve

<issue_title>Our charm tests that inject ops from github branch sometime trip on git reference</issue_title>
<issue_description>```
Run if [ -e "requirements.txt" ]; then
if [ -e "requirements.txt" ]; then
sed -i -e "/^ops[ ><=]/d" -e "/canonical/operator/d" -e "/#egg=ops/d" requirements.txt
echo -e "\ngit+$GITHUB_SERVER_URL/$GITHUB_REPOSITORY@$GITHUB_SHA#egg=ops" >> requirements.txt
sed -i -e "/^ops-scenario[ ><=]/d" -e "/^ops[testing][ ><=]/d" requirements.txt
echo -e "\ngit+$GITHUB_SERVER_URL/$GITHUB_REPOSITORY@$GITHUB_SHA#egg=ops-scenario&subdirectory=testing" >> requirements.txt
elif [ -e "uv.lock" ]; then
uv remove ops --optional dev --frozen || echo "maybe ops[testing] is not a dev dependency"
uv remove ops-scenario --optional dev --frozen || echo "maybe ops-scenario is not a dev dependency"
uv remove ops --frozen
uv add git+$GITHUB_SERVER_URL/$GITHUB_REPOSITORY@$GITHUB_SHA --raw-sources --prerelease=if-necessary-or-explicit
uv add git+$GITHUB_SERVER_URL/$GITHUB_REPOSITORY@$GITHUB_SHA#subdirectory=testing --optional dev --raw-sources --prerelease=if-necessary-or-explicit
else
echo "Error: no requirements.txt or uv.lock file found"
exit 1
fi
shell: /usr/bin/bash -e {0}
error: The dependency ops-scenario could not be found in `project.optional-dependencies.dev`
maybe ops-scenario is not a dev dependency
Using CPython 3.12.3 interpreter at: /usr/bin/python3
Creating virtual environment at: .venv
Updating https://github.com/canonical/operator (92969e345187522c9d9722e5535)
error: Git operation failed
Caused by: failed to find branch, tag, or commit `92969e31e6169ccd1ca245187522c9d9722e5535`
Caused by: process didn't exit successfully: `/usr/bin/git rev-parse '92969e31e6169ccd1ca245187522c9d9722e5535^0'` (exit status: 128)
--- stdout
92969e3^0

--- stderr
fatal: ambiguous argument '92969e31e6169ccd1ca245187522c9d9722e5535^0': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git [...] -- [...]'
</issue_description>

<agent_instructions>We need to adjust the workflows that inject Ops via a git reference to instead check out the repo and build wheels (for ops but also probably ops-scenario and ops-tracing) and adjust the workflows to inject the wheel into the dependencies instead.</agent_instructions>

## Comments on the Issue (you are @copilot in this section)

<comments>
<comment_new><author>@dimaqq</author><body>
Weirdly only one test out of three we run in parallel trips on this.
I wonder if this could have something to do with distributed nature of GitHub:
- I push a commit to my branch with an open PR
- GitHub Actions job is kicked off
- The checkout step works fine evidently
- But the python dep reference pointing to the same commit cannot be resolved?

![Image](https://github.com/user-attachments/assets/cdf7a020-8ba8-4c1d-a284-81fbc5c7a7ec)</body></comment_new>
<comment_new><author>@dimaqq</author><body>
I've started a discussion upstream: https://github.com/orgs/community/discussions/164558</body></comment_new>
<comment_new><author>@benhoyt</author><body>
Build ops from local checkout and inject that into the 3rd party charm.

Alternatively: Retry! or sleep. But the first option seems much cleaner.</body></comment_new>
</comments>

Fixes Our charm tests that inject ops from github branch sometime trip on git reference #1843

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…rkflows Co-authored-by: tonyandrewmeyer <826522+tonyandrewmeyer@users.noreply.github.com>