Skip to content

Conversation

@ogayot
Copy link
Member

@ogayot ogayot commented Oct 6, 2025

When building the debian package, dh_missing complains that files in probert/rtnetlink/tests are not installed. We could add them to debian/not-installed but really we don't want them in the package at all. Drop them along with other existing test modules.

^ This is required for building console-conf with recent probert.

   dh_missing -O--buildsystem=pybuild
dh_missing: warning: usr/lib/python3.13/dist-packages/probert/tests/rtnetlink/__init__.py exists in debian/tmp but is not installed to anywhere (related file: "debian/tmp/usr/lib/python3.13/dist-packages/probert/rtnetlink/__init__.py")
dh_missing: warning: usr/lib/python3.13/dist-packages/probert/tests/rtnetlink/common.py exists in debian/tmp but is not installed to anywhere 
dh_missing: warning: usr/lib/python3.13/dist-packages/probert/tests/rtnetlink/test_addr.py exists in debian/tmp but is not installed to anywhere 
dh_missing: warning: usr/lib/python3.13/dist-packages/probert/tests/rtnetlink/test_link.py exists in debian/tmp but is not installed to anywhere 
dh_missing: warning: usr/lib/python3.13/dist-packages/probert/tests/rtnetlink/test_listener.py exists in debian/tmp but is not installed to anywhere 
dh_missing: warning: usr/lib/python3.13/dist-packages/probert/tests/rtnetlink/test_route.py exists in debian/tmp but is not installed to anywhere 
dh_missing: error: missing files, aborting

	While detecting missing files, dh_missing noted some files with a similar name to those
	that were missing.  This error /might/ be resolved by replacing references to the
	missing files with the similarly named ones that dh_missing found - assuming the content
	is identical.

	As an example, you might want to replace:
	 * debian/tmp/usr/lib/python3.13/dist-packages/probert/rtnetlink/__init__.py
	with:
	 * usr/lib/python3.13/dist-packages/probert/tests/rtnetlink/__init__.py
	in a file in debian/ or as argument to one of the dh_* tools called from debian/rules.
	(Note it is possible the paths are not used verbatim but instead directories 
	containing or globs matching them are used instead)

	Alternatively, add the missing file to debian/not-installed if it cannot and should not
	be used.

	The following debhelper tools have reported what they installed (with files per package)
	 * dh_install: probert (0), probert-common (28), probert-firmware (1), probert-network (8), probert-storage (12)
	 * dh_installdocs: probert (1), probert-common (0), probert-firmware (0), probert-network (0), probert-storage (0)
	If the missing files are installed by another tool, please file a bug against it.
	When filing the report, if the tool is not part of debhelper itself, please reference the
	"Logging helpers and dh_missing" section from the "PROGRAMMING" guide for debhelper (10.6.3+).
	  (in the debhelper package: /usr/share/doc/debhelper/PROGRAMMING.md.gz)
	Be sure to test with dpkg-buildpackage -A/-B as the results may vary when only a subset is built
	If the omission is intentional or no other helper can take care of this consider adding the
	paths to debian/not-installed.
make: *** [debian/rules:6: binary] Error 255
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

When building the debian package, dh_missing complains that files in
probert/rtnetlink/tests are not installed. We could add them to
debian/not-installed but really we don't want them in the package at all.
Drop them along with other existing test modules.

Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
Copy link
Collaborator

@Chris-Peterson444 Chris-Peterson444 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@dbungert dbungert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ogayot ogayot merged commit e15fb5d into canonical:main Oct 7, 2025
2 checks passed
@ogayot ogayot deleted the no-tests-in-package branch October 7, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants