pycloudlib: increase a variety of retry frequencies#115
Merged
Conversation
The previous implementation assumed that `client.connect` would take ~no time. This isn't the case, it will sometimes block for 10s of seconds, which meant that the "10 minute" wait could sometimes be substantially longer than that.
`self.execute` generally fails the first time it's executed, but will often succeed much sooner than 10s after: reducing the interval between attempts reduces the time we wait for boot of instances.
LXD instances are very unlikely to have an IP address when we first launch them, but they generally gain an IP address much earlier than 20s after boot. Reducing this interval substantially speeds up booting LXD instances accessed via SSH.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When investigating the relative performance of execution methods for #114, I found that a lot of our slow launch speeds were due to long sleeps between retries. This PR tweaks a variety of them, and fixes #111 as well.