gce: fallback to GOOGLE_CLOUD_PROJECT if project is not specified#162
Merged
Conversation
Collaborator
Author
|
@lucasmoura I think I understand your comment (thanks!), but that only applies to |
5cdae78 to
1d41b66
Compare
Collaborator
Author
|
PR updated and tested. |
lucasmoura
approved these changes
Oct 5, 2021
Collaborator
Author
|
Thanks! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When initializing GCE fallback to the GOOGLE_APPLICATION_CREDENTIALS and
GOOGLE_CLOUD_PROJECT environment variables if credentials_path or
project are not specified.