Set correct xenial image for LXD#45
Merged
Merged
Conversation
blackboxsw
reviewed
Nov 12, 2020
| if release == "xenial": | ||
| # xenial needs to launch images:ubuntu/16.04/cloud | ||
| # because it contains the HWE kernel which has vhost-vsock support | ||
| return self.XENIAL_VM_IMAGE |
Collaborator
There was a problem hiding this comment.
let's rename this to XENIAL_IMAGE_VSOCK_SUPPORT
lucasmoura
force-pushed
the
fix-xenial-image-on-lxd
branch
from
1b59fa5 to
98c45c2
Compare
Author
|
@blackboxsw Updated |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are only using the
images:ubuntu/16.04/cloudwhen we are creating virtual machines. However, this is wrong, since we always need to use that machine, for containers and virtual machines. The reason for that is that other xenial images will not have the necessary requirements to allow the use oflxc execcommands