feat: Add the ability to specify which Oracle VCN to use through the config file#454
Merged
a-dubs merged 1 commit intocanonical:mainfrom Jan 27, 2025
Merged
Conversation
Bryzizzle
force-pushed
the
add-vcn-option-in-config
branch
2 times, most recently
from
66e9a09 to
cf53c36
Compare
Bryzizzle
force-pushed
the
add-vcn-option-in-config
branch
4 times, most recently
from
9824182 to
7a7ffda
Compare
… file When there are multiple virtual cloud networks (VCNs) available on an Oracle compartment, pycloudlib will use the newest VCN available, which might not be desired. Currently, the VCN selection functionality is present within the cloud class level, however it cannot be set through the config file. This patch modifies the `pycloudlib/oci/cloud.py` file to retrieve the `vcn_name` key from config and use it to force a VCN to use. A commented entry is also included in the `pycloudlib.toml.template` for reference.
Bryzizzle
force-pushed
the
add-vcn-option-in-config
branch
from
7a7ffda to
01d8b2a
Compare
Contributor
|
fire in the hole! soooooooooooo glad to finally be able to use this config from my toml file |
a-dubs
approved these changes
Jan 27, 2025
Contributor
a-dubs
left a comment
a-dubs
left a comment
There was a problem hiding this comment.
lgtm!! this is a good bandaid solution until we do the full configuration overhaul!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there are multiple virtual cloud networks (VCNs) available on an Oracle compartment, pycloudlib will use the newest VCN available, which might not be desired. Currently, the VCN selection functionality is present within the cloud class level, however it cannot be set through the config file. This patch modifies the
pycloudlib/oci/cloud.pyfile to retrieve thevcn_namekey from config and use it to force a VCN to use. A commented entry is also included in thepycloudlib.toml.templatefor reference.