-
Notifications
You must be signed in to change notification settings - Fork 37
Fix lxd related issues #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
6c86795
Fix LXD image_serial for vms
4f0a756
Add key type to ssh keys generated by paramiko
4cb448f
Fix launch of LXD instances with no name
e4f47bb
Only use images remote for xenial vm images
6304e83
Split LXD containers and vm into distinct classes
37155cd
Add travis file
29ee914
Keep running lxd commands as sudo
0afe7ee
Update LXD abstraction
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| language: python | ||
| dist: bionic | ||
|
|
||
|
|
||
| install: | ||
| # Required so `git describe` will definitely find a tag; see | ||
| # https://github.com/travis-ci/travis-ci/issues/7422 | ||
| - git fetch --unshallow | ||
|
|
||
| matrix: | ||
| fast_finish: true | ||
| include: | ||
| - name: run-lxd-example | ||
| install: | ||
| - pip install -r requirements.txt | ||
| script: | ||
| - sudo apt-get remove --yes --purge lxd lxd-client | ||
| - sudo rm -Rf /var/lib/lxd | ||
| - sudo snap install lxd | ||
| - sudo lxd init --auto | ||
| - sudo usermod -a -G lxd $USER | ||
| - sg lxd -c "python examples/lxd.py" | ||
| - name: run-cloudinit-integration-tests | ||
| install: | ||
| - pip install -r requirements.txt | ||
| - pip install pytest | ||
| script: | ||
| - sudo apt-get remove --yes --purge lxd lxd-client | ||
| - sudo rm -Rf /var/lib/lxd | ||
| - sudo snap install lxd | ||
| - sudo lxd init --auto | ||
| - sudo usermod -a -G lxd $USER | ||
| - git clone https://github.com/canonical/cloud-init.git | ||
| - cd cloud-init | ||
| - sg lxd -c "pytest tests/integration_tests/" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably use
toxand only run the CI tests we run in cloud-init: that should comfortably exercise most of the pycloudlib functionality we use. Given that I'm going to be pushing a cloud-init commit to make that easier to do, let's leave this as-is and I'll propose a separate change which does that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Except tox might have a hard time using the current pycloudlib rather than cloud-init's default one, so I'll give this further thought.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that was exactly why I have not used tox :(