Skip to content

Add sudo option to instance execute #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OddBloke merged 2 commits into from
Nov 17, 2020
Merged

Add sudo option to instance execute #54

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3df3657
Add sudo option to instance execute
TheRealFalcon Nov 16, 2020
e9791ba
[squash] Adding -- to sudo per review
TheRealFalcon Nov 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pycloudlib/instance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,8 @@ def _run_command(self, command, stdin):
"""Run command in the instance."""
return self._ssh(list(command), stdin=stdin)

def execute(self, command, stdin=None, description=None, **kwargs):
def execute(self, command, stdin=None, description=None, *, use_sudo=False,
**kwargs):
"""Execute command in instance, recording output, error and exit code.

Assumes functional networking and execution with the target filesystem
Expand All @@ -150,13 +151,16 @@ def execute(self, command, stdin=None, description=None, **kwargs):
`['sh', '-c', command]`
stdin: bytes content for standard in
description: purpose of command
use_sudo: boolean to run the command as sudo

Returns:
Result object

"""
if isinstance(command, str):
command = ['sh', '-c', command]
if use_sudo:
command = ['sudo', '--'] + command

self._log.info('executing: %s', shell_quote(command))
if description:
Expand Down