interfaces/docker-support: add exec "/bin/runc"#7090
Closed
tianon wants to merge 1 commit into
Closed
Conversation
mvo5
approved these changes
Jul 11, 2019
Contributor
mvo5
left a comment
mvo5
left a comment
There was a problem hiding this comment.
LGTM but needs an ACK from jdstrand too.
Contributor
|
@tianon it looks like the CLA failed, can you repush with an email that has signed the CLA or sign the CLA with your new email? |
anonymouse64
approved these changes
Jul 11, 2019
jdstrand
changed the title
Contributor
Author
|
Welp, I signed the CLA and rebased/force pushed to force a recheck but it still comes back rejected. 😕 |
zyga
approved these changes
Jul 12, 2019
Contributor
zyga
left a comment
zyga
left a comment
There was a problem hiding this comment.
+1, I'll monitor the CLA situation.
Newer runC applied further improvements to their CVE-2019-5736 mitigation in opencontainers/runc#1984 which change the nature of our apparmor denial from `/` to `/bin/runc` (which I have also commented on https://bugs.launchpad.net/apparmor/+bug/1820344 about). See also #6610. Signed-off-by: Tianon Gravi <tianon@debian.org>
Contributor
Author
|
As a hail mary I rebased and force pushed again to trigger the CLA check again (hoping perhaps something just needed to propagate) and still no dice. 😕 |
Contributor
|
@tianon in the interest of time, are you okay if I open a new PR with your change committed from me? |
Contributor
Author
|
Absolutely! |
|
#7106 is the new PR. Closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer runC applied further improvements to their CVE-2019-5736 mitigation in opencontainers/runc#1984 which change the nature of our apparmor denial from
/to/bin/runc(which I have also commented on https://bugs.launchpad.net/apparmor/+bug/1820344 about).See also #6610.
cc @anonymouse64