Skip to content

Show bit fields of Variables that are added to a Map. #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christiansandberg merged 3 commits into from
Sep 24, 2019
Merged

Show bit fields of Variables that are added to a Map. #162

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ced476
Show bit fields of Variables that are added to a Map.
Sandyman Sep 24, 2019
32f974b
Removed redundant calculations. Removed length in favour of start_bit…
Sandyman Sep 24, 2019
e33077f
Slightly changed the log message for better readability.
Sandyman Sep 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions canopen/pdo/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,8 +415,11 @@ def add_variable(self, index, subindex=0, length=None):
if length is not None:
# Custom bit length
var.length = length
logger.info("Adding %s (0x%X:%d, %d bits) to PDO map",
var.name, var.index, var.subindex, var.length)
# We want to see the bit fields within the PDO
start_bit = var.offset
end_bit = start_bit + var.length - 1
logger.info("Adding %s (0x%X:%d) at bits %d - %d to PDO map",
var.name, var.index, var.subindex, start_bit, end_bit)
self.map.append(var)
self.length += var.length
except KeyError as exc:
Expand Down