Allow for timestamps of other types than float #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… then check whether it exists before doing the subtraction. This way, we can potentially use other types for the timestamp, as long as subtracting two of them result in an integer/float (meaning seconds).
Sandyman
changed the title
Sandyman
changed the title
Sandyman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In stead of assigning 0 directly to a timestamp member in
canopen.pdo.Map, set it to None in the constructor, then check whether it exists before doing the subtraction inon_message. This way, we can potentially use other types for the timestamp, as long as subtracting two of them results in a float (meaning seconds).