Skip to content

Conversation

@stan-dalencon
Copy link

In EDS parsing, add load of [DummyUsage] section in order to allow PDO Dummy Mapping as defined in §4.6.2 - "Mapping of dummy entries" of CiA 306 (v1.3)

@christiansandberg
Copy link
Member

Could you also add a simple test? Modify the sample.eds file and add a check in test_eds.py.

@stan-dalencon
Copy link
Author

Could you also add a simple test? Modify the sample.eds file and add a check in test_eds.py.

Sure, I add two tests:

  • one with defined dummy, to check var properties
  • one with an undefined dummy, to check that KeyError exception is thrown

@stan-dalencon
Copy link
Author

@christiansandberg : Don't know why CI build failed especially in a part I didn't modify, any idea ?

@christiansandberg christiansandberg merged commit 8cfdf75 into canopen-python:master Jan 29, 2020
@christiansandberg
Copy link
Member

Thanks! The failing test was due to a timing issue.

@stan-dalencon stan-dalencon deleted the feature/eds_dummy_mapping branch January 29, 2020 14:38
@stan-dalencon
Copy link
Author

Thanks! The failing test was due to a timing issue.

Ok, thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants